This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
Ok with the suggested changes (mostly stylistic). Bracketed points are not required to be addressed for the commit.+ + if ((s->n_type & BFD_MACH_O_N_TYPE) == BFD_MACH_O_N_INDR)
[ Maybe we should create a macro to test for indirect symbols ]
+ /* A pointer to the referenced symbol will be stored in the udata + field. Use that to find the string index. */ + s->symbol.value = + ((bfd_mach_o_asymbol *)s->symbol.udata.p)->symbol.udata.i;
[ One issue is that we don't follow the BFD convention for indirect symbols. To be fixed later ]
[ One question: does it make sense to output the indirect name here and therefore avoiding taking care of indirect symbols while sorting ? ]
+ }
Please don't use the raw buffer buf. Instead use mach_o_dylib_module[_64]_external. I know it is boring because of 32/64.
+ + bfd_h_put_32 (abfd, cmd->indirect_syms[i], &raw);
[ Ditto (although might be considered as too trivial) ]
+ bfd_h_put_32 (abfd, v, raw);
[ Ditto ]
+ if (type == BFD_MACH_O_N_INDR) return 3;
GNU style issue: not on the same line!
+ qsort (symbols, (size_t) nin, sizeof (void *), bfd_mach_o_cf_symbols);
[ Unfortunately qsort is not stable! ]
=== applied patch attached FTR.
Attachment:
12010311-write-dysymtab.txt
Description: Text document
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |