This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: PATCH: PR ld/12451: --build-id doesn't work

From: nick clifton <nickc at redhat dot com>
To: "H.J. Lu" <hjl dot tools at gmail dot com>, binutils at sourceware dot org, Jakub Jelinek <jakub at redhat dot com>
Date: Wed, 14 Dec 2011 12:00:48 +0000
Subject: Re: PATCH: PR ld/12451: --build-id doesn't work
References: <20111214000103.GA29059@intel.com> <20111214095334.GH6550@bubble.grove.modra.org>

Hi Alan,

I reckon we should exclude SHT_NOBITS sections from the checksum.

Sorry - I did not see this email before committing the patch to 12451.

It
seems a complete waste of time to me.  We already checksum their size
and address when processing program headers and section headers.

I agree. What do you think of the attached modification to the original patch ?

Cheers
  Nick

Attachment: elfcode.h.patch
Description: Text document

Follow-Ups:
- Re: PATCH: PR ld/12451: --build-id doesn't work
  - From: Alan Modra

References:
- PATCH: PR ld/12451: --build-id doesn't work
  - From: H.J. Lu
- Re: PATCH: PR ld/12451: --build-id doesn't work
  - From: Alan Modra

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]