This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Linker garbage collection should not collect unreferenced symbols if they are externally visible and export-dynamic is on

From: Sriraman Tallam <tmsriram at google dot com>
To: binutils <binutils at sourceware dot org>, Ian Lance Taylor <iant at google dot com>, Cary Coutant <ccoutant at google dot com>, Paul Pluzhnikov <ppluzhnikov at google dot com>
Date: Thu, 27 Oct 2011 16:32:47 -0700
Subject: Linker garbage collection should not collect unreferenced symbols if they are externally visible and export-dynamic is on

Hi,

   There is a bug in gold. Linker garbage collection should not
collect unreferenced symbols if they are externally visible and
export-dynamic is on. They do right now. The following patch fixes it.

	* symtab.h (Symbol_table::gc_mark_symbol_for_shlib): Rename to
	gc_mark_symbol.
	* symtab.cc (Symbol_table::gc_mark_symbol_for_shlib): Rename to
	gc_mark_symbol.
	Change to just keep the section associated with symbol.
	(Symbol_table::add_from_relobj): Mark symbols as not garbage when
	they are externally visible and --export-dynamic is turned on.
	(Symbol_table::gc_mark_dyn_syms): Call gc_mark_symbol.

Comments?

Thanks,
-Sri.

Attachment: gold_patch.txt
Description: Text document

Follow-Ups:
- Re: Linker garbage collection should not collect unreferenced symbols if they are externally visible and export-dynamic is on
  - From: Ian Lance Taylor

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]