This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: Ping: [RFA]: New port: Epiphany
Quoting Nick Clifton <nickc@redhat.com>:
So, I have checked your patches in. Thanks very much for submitting them.
I've seen you've did some more cleanups. Thanks.
There are a few issues, though:
- The config.sub sync is missing.
- As I understand it, the Copyright years should reflect all the years in
which the code has been written. As such, I had used the union of the
Copyright years of any files copied from wholesale, and the years in which
the Epiphany code has been written - mostly 2009 and 2011.
- You seem to have used the first gas/doc/as.texinfo and opcodes/disassemble.c
patch versions, from before Josef S. Myers comment to avoid option
documentation duplication. I have adjusted as.texinfo in a later
version accordingly. I've also moved ARCH_epiphany down in disassemble.c
to put it into the right alphasorted spot. See attached patch below.
Are you willing to act as the maintainer for the Epiphany port of binutils ?
Yes. I am an employee of Embecosm now, and expect to do more Epiphany work
in the future.
2011-10-25 Joern Rennecke <joern.rennecke@embecosm.com>
gas:
* doc/as.texinfo [EPIPHANY]: Include c-epiphany.texi to avoid
duplication.
opcodes:
* disassemble.c (ARCH_epiphany): Move into alphasorted spot.
Index: gas/doc/as.texinfo
===================================================================
RCS file: /cvs/src/src/gas/doc/as.texinfo,v
retrieving revision 1.242
diff -p -r1.242 as.texinfo
*** gas/doc/as.texinfo 25 Oct 2011 11:18:08 -0000 1.242
--- gas/doc/as.texinfo 25 Oct 2011 17:26:29 -0000
*************** Warn when a nop after a 32-bit multiply
*** 852,867 ****
The following options are available when @value{AS} is configured for the
Adapteva EPIPHANY series.
! @table @gcctabopt
!
! @item -mepiphany
! Specifies that the both 32 and 16 bit instructions are allowed. This is the
! default behavior.
! @item -mepiphany16
! Restricts the permitted instructions to just the 16 bit set.
- @end table
@end ifset
@ifset I80386
--- 852,872 ----
The following options are available when @value{AS} is configured for the
Adapteva EPIPHANY series.
! @ifclear man
! @xref{Epiphany Options}, for the options available when @value{AS} is
! configured for an Epiphany processor.
! @end ifclear
! @ifset man
! @c man begin OPTIONS
! The following options are available when @value{AS} is configured for
! an Epiphany processor.
! @c man end
! @c man begin INCLUDE
! @include c-epiphany.texi
! @c ended inside the included file
! @end ifset
@end ifset
@ifset I80386
Index: opcodes/disassemble.c
===================================================================
RCS file: /cvs/src/src/opcodes/disassemble.c,v
retrieving revision 1.81
diff -p -r1.81 disassemble.c
*** opcodes/disassemble.c 25 Oct 2011 11:18:16 -0000 1.81
--- opcodes/disassemble.c 25 Oct 2011 17:26:29 -0000
***************
*** 26,32 ****
#define ARCH_alpha
#define ARCH_arc
#define ARCH_arm
- #define ARCH_epiphany
#define ARCH_avr
#define ARCH_bfin
#define ARCH_cr16
--- 26,31 ----
***************
*** 35,40 ****
--- 34,40 ----
#define ARCH_d10v
#define ARCH_d30v
#define ARCH_dlx
+ #define ARCH_epiphany
#define ARCH_fr30
#define ARCH_frv
#define ARCH_h8300