Re: PATCH: PR ld/12730: regression] crash when allocating in a static constructor

[Thomas Schwinge <tschwinge at gnu dot org>]

Hallo!

On Sat, 7 May 2011 06:39:42 -0700, "H.J. Lu" <hjl.tools@gmail.com> wrote:
> Here is the updated patch.  OK to install?

(Has been in the mean time.)

> ld/testsuite/
> 
> 2011-05-07  H.J. Lu  <hongjiu.lu@intel.com>
> 
> 	PR ld/12730
> 	* ld-elf/elf.exp (array_tests): Add "pr12730".
> 	(array_tests_pie): New.
> 	(array_tests_static): Add -static for ""static init array mixed".
> 	Add "static pr12730".  Run array_tests_pie for Linux.

> diff --git a/ld/testsuite/ld-elf/elf.exp b/ld/testsuite/ld-elf/elf.exp
> index 73a417c..6808d8a 100644
> --- a/ld/testsuite/ld-elf/elf.exp
> +++ b/ld/testsuite/ld-elf/elf.exp
> [...]
> +
> +# Run PIE tests only on Linux.
> +if { [istarget "*-*-linux*"] } {
> +    run_ld_link_exec_tests $xfails $array_tests_pie
> +}
> +
> [...]

Why, oh why?  :-)

ld/testsuite/

	* ld-elf/elf.exp: Execute array_tests_pie tests on *-*-gnu*, too.

---
 ld/testsuite/ld-elf/elf.exp |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/ld/testsuite/ld-elf/elf.exp b/ld/testsuite/ld-elf/elf.exp
index ff0f03e..da24bed 100644
--- a/ld/testsuite/ld-elf/elf.exp
+++ b/ld/testsuite/ld-elf/elf.exp
@@ -150,8 +150,8 @@ set array_tests_static {
 set xfails [list "*-*-netbsdelf*"]
 run_ld_link_exec_tests $xfails $array_tests
 
-# Run PIE tests only on Linux.
-if { [istarget "*-*-linux*"] } {
+if { [istarget *-*-linux*]
+     || [istarget *-*-gnu*] } {
     run_ld_link_exec_tests $xfails $array_tests_pie
 }
 
-- 
tg: (38b56ed..) hurd/testsuite (depends on: master)

OK to commit?  (Or are such changes even obvious and don't need
approval?)


GrÃÃe,
 Thomas

Attachment: pgp00000.pgp
Description: PGP signature