This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] C6X automagic cantinuwing marking


On Tue, 3 May 2011, Paul Brook wrote:

> +    /* Unwind info attached to an .ARM.exidx section.  */

Not ARM, c6xabi.

> +/* Increase the size of EXIDX_SEC by ADJUST bytes.  ADJUST mau be negative.  */

Typo "mau".

> +  /* Walk all text sections in order of increasing VMA.  Eilminate duplicate

Typo "Eilminate".

> +  /* If the high bit of the first word is clear, and the bit pattern is not 0x1
> +     (EXIDX_CANTUNWIND), this is an offset to an .ARM.extab entry.  */

Another stray ARM reference.

> +@kindex --no-merge-exidx-entries
> +The @samp{--no-merge-exidx-entries} switch disables the merging of adjacent exidx entries in debuginfo.

It's unwind information, not debug info.

> +    *(.glue_7)
> +    *(.v4_bx)

Stray ARM section references in linker script.

> +    *(.glue_7)
> +    *(.v4_bx)

Likewise.

OK with those issues fixed.  If the typos come from the ARM code you'll 
probably want to fix them there as well in a separate patch.

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]