This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] ARM: objdump produces incorrect disassembly on multiple inputs


Hi Paul,

/src/binutils-current/binutils/testsuite/binutils-all/arm/simple.s:
assembly failed

Sounds like that patch needs to be backed out until I either make the
test case's assembly code more generic or, more likely, modify the
driving script so it is only invoked for certain toolkits.

Or do what I have done and remove the .type and .size directives from simple.s. They are not needed for the test and they have different semantics on COFF based targets, so removing them is the easy solution.


Cheers
  Nick

binutils/testsuite/ChangeLog
2011-04-11  Nick Clifton  <nickc@redhat.com>

	* binutils-all/arm/simple.s: Fix assembly problems for COFF based
	ARM toolchaisn by removing .type and .size directives.

--- binutils-all/arm/simple.s   8 Apr 2011 11:42:18 -0000       1.1
+++ binutils-all/arm/simple.s   11 Apr 2011 15:12:29 -0000      1.2
@@ -8,7 +8,7 @@ l:
     .text
     .align    2
     .global    f1
-    .type    f1, %function
+
 f1:
     str    fp, [sp, #-4]!
     add    fp, sp, #0
@@ -19,10 +19,10 @@ f1:
     bx    lr
     .align    2
     .word    l
-    .size    f1, .-f1
+
     .align    2
     .global    main
-    .type    main, %function
+
 main:
     stmfd    sp!, {fp, lr}
     add    fp, sp, #4
@@ -31,5 +31,5 @@ main:
     .word    1717986919
     .word    -1840700269
     .word    l
-    .size    main, .-main
+
     .ident    "GCC: (Sourcery G++ 2011.03) 4.5.1"


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]