This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch binutils]: Add --preprocessor-arg option to windres tool

Hi Kai,

This patch adds feature to windres tool, so that user can pass via
--preprocessor-arg additional options to the preprocessor.

2011-04-08 Kai Tietz

	* windres.c (usage): Add new --preprocessor-arg option.
	(option_values): Add new OPTION_PREPROCESSOR_ARG enumerator.
	(option long_options): Add preprocessor-arg option.
	(main): Handle it.

The patch itself is OK, but you need to extend it. In particular:

* Document the new option in binutils/binutils.texi.

* Mention the new feature in binutils/NEWS.

* Optional, but very helpful: Add a test to binutils/testsuite/binutils-all/windres to check that the new feature works.

Cheers
  Nick


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]