Re: [PATCH] R_C6000_EHTYPE

[Nick Clifton <nickc at redhat dot com>]

Hi Paul,

> 2011-04-07  Paul Brook<paul@codesourcery.com>
>
> 	bfd/
> 	* elf32-tic6x.c (elf32_tic6x_howto_table,
> 	elf32_tic6x_howto_table_rel, (elf32_tic6x_gc_sweep_hook,
> 	elf32_tic6x_relocate_section, elf32_tic6x_check_relocs):
> 	Add R_C6000_EHTYPE.
>
> 	gas/
> 	* config/tc-tic6x.c (s_ehtype): New function.
> 	(md_pseudo_table): Add "ehtype".
> 	(tic6x_fix_adjustable, md_apply_fix): BFD_RELOC_C6000_EHTYPE.
> 	* doc/c-tic6x.texi: Document .ehtype directive.
>
> 	ld/testsuite/
> 	* ld-tic6x/ehtype-reloc-1-rel.d: New test.
> 	* ld-tic6x/ehtype-reloc-1.d: New test.
> 	* ld-tic6x/ehtype-reloc-1.s: New test.

Approved - please apply - although...

+  if (exp.X_op != O_symbol)
+    {
+      as_bad (_("expected symbol"));
+      return;
+    }

...It might be nice to have a slightly more informative error message here.

Cheers
  Nick