This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: PR binutils/12639: nm/readelf failed to detect corrupted symtab


On Tue, Apr 05, 2011 at 11:02:06PM -0700, H.J. Lu wrote:
> d) nm/readelf reports error on those bad input files.
> 
> That is what my patch implements.

Not exactly.  Your elfcode.h:elf_slurp_symbol_table patch issues a
message but doesn't return an error.  I think you ought to call
bfd_set_error and exit the function via error_return.

On the readelf patch, I'd be inclined to report "Bad symtab" at the
end of the symbol table and not special case mips.

-- 
Alan Modra
Australia Development Lab, IBM


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]