This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
The patch looks ok, though I think the testcases could use some reorganisation. I'd prefer two assembly files, one with insns valid in both ARM and Thumb mode, the other which is only valid in ARM mode. Assemble both in both modes. There should already be existing tests (e.g. sp-pc-usage-t) that cover the former.
+@ test case of ADD{S} and SUB{S} instructions in ARM modeToo vague. You're testing use of SP in these insns.
For the negative test case, I can adjust the comment to this: # Test of invalid operands for ADD{S} and SUB{S} instructions # in Thumb2 mode. The instruction form being testing # involves having the first 2 operands be SP.
+ .file "s6163c.c"Looks bogus.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |