This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] MIPS/GAS: Fix register use annotation of ALNV.PS
- From: Richard Sandiford <rdsandiford at googlemail dot com>
- To: "Maciej W. Rozycki" <macro at codesourcery dot com>
- Cc: binutils at sourceware dot org
- Date: Sat, 26 Feb 2011 09:39:58 +0000
- Subject: Re: [PATCH] MIPS/GAS: Fix register use annotation of ALNV.PS
- References: <alpine.DEB.1.10.1102250057590.20460@tp.orcam.me.uk>
"Maciej W. Rozycki" <macro@codesourcery.com> writes:
> The ALNV.PS instruction lacks register use annotation for its general
> register argument. As a result it can be reordered into a branch delay
> slot even if it reads a register that the branch writes. Here's a fix.
Ouch. So easily done. Did someone find out the hard way, or was this
just by inspection?
> 2011-02-25 Maciej W. Rozycki <macro@codesourcery.com>
>
> opcodes/
> * mips-opc.c (mips_builtin_opcodes): Correct register use
> annotation of "alnv.ps".
>
> gas/testsuite/
> * gas/mips/alnv_ps-swap.d: New test for ALNV.PS instruction
> branch swapping.
> * gas/mips/alnv_ps-swap.s: Source for the new test.
> * gas/mips/mips.exp: Run the new test.
OK, thanks.
Richard