This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Dangling pointer in ICF from c_str method.

From: Ian Lance Taylor <iant at google dot com>
To: Richard Guenther <rguenther at suse dot de>
Cc: Sriraman Tallam <tmsriram at google dot com>, binutils <binutils at sourceware dot org>, Doug Kwan (éæå) <dougkwan at google dot com>
Date: Thu, 03 Feb 2011 12:42:20 -0800
Subject: Re: Dangling pointer in ICF from c_str method.
References: <AANLkTimrzaPG-i0UPpdtYy9Hk8f=8PzZ1+GFxsmTvQ17@mail.gmail.com> <alpine.LNX.2.00.1102031040380.17230@zhemvz.fhfr.qr>

Richard Guenther <rguenther@suse.de> writes:

> On Wed, 2 Feb 2011, Sriraman Tallam wrote:
>
>> Hi,
>> 
>>    Doug Kwan found a bug in ICF caused by a dangling pointer from
>> using c_str on a temporary string object. I have attached a patch to
>> fix it. I suspect this as the cause of bug  reported in :
>> http://sourceware.org/bugzilla/show_bug.cgi?id=12388. Richard, could
>> you please see if this patch fixes the bug as I am unable to reproduce
>> it.
>
> It doesn't apply to the 2.21 release for me.  I'll pick it up when
> 2.21.1 is released.

I applied Sri's patch to binutils 2.21 branch.

Ian

References:
- Dangling pointer in ICF from c_str method.
  - From: Sriraman Tallam
- Re: Dangling pointer in ICF from c_str method.
  - From: Richard Guenther

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]