This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

[PATCH][GOLD] Fix dangling pointer bug due to premature unlock.

From: Doug Kwan (éæå) <dougkwan at google dot com>
To: binutils <binutils at sourceware dot org>, Ian Lance Taylor <iant at google dot com>
Cc: Cary Coutant <ccoutant at google dot com>, Sriraman Tallam <tmsriram at google dot com>
Date: Tue, 25 Jan 2011 01:20:41 -0800
Subject: [PATCH][GOLD] Fix dangling pointer bug due to premature unlock.

Hi

   This fixes a bug in which an object is released too early, causing
a pointer to point to unmapped memory.  My fix is to move the locking
code to the caller of get_section_contents() and replace the original
locking code with a check.  This has been tested on x86_64.

-Doug


2011-01-25  Doug Kwan  <dougkwan@google.com>

        * gold/icf.cc (get_section_contents): Instead of locking object in
        two places, ask caller to lock it before calling. Add an assert
        to check that object is locked in the first iteration.
        (match_sections): Lock object before calling get_section_contents()
        in the first iteration.

Attachment: patch.txt
Description: Text document

Follow-Ups:
- Re: [PATCH][GOLD] Fix dangling pointer bug due to premature unlock.
  - From: Ian Lance Taylor

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]