RE: Bug fix for gldelf_i386_place_orphan in elf32.em [version 2.20.1]

["Sheng, Yongjie" <yongjie dot sheng at intel dot com>]

Alan,

Thanks for your quick response.

Please see my small linker-test.tgz test package.
With "-gstabs" compiling option, a hello world (binutils-2.20.1) links with a mangled-section.o(two section names are mangled, being orphan sections).
It will crash in running (in ld-linux.so.2).
It will not crash if built with binutils-2.17.50 (FC8).

Yours sincerely,
Sheng, Yongjie (Sam)

-----Original Message-----
From: Alan Modra [mailto:amodra@gmail.com] 
Sent: Wednesday, January 12, 2011 3:39 PM
To: Sheng, Yongjie
Cc: binutils@sources.redhat.com
Subject: Re: Bug fix for gldelf_i386_place_orphan in elf32.em [version 2.20.1]

On Wed, Jan 12, 2011 at 03:01:15PM +0800, Sheng, Yongjie wrote:
> The above code set the hold[orphan_nonalloc] name as ".comment", but os as lookup->prev. It should be lookup itself, right?

No.  The idea is to place orphan non-alloc sections before debug
sections, or when there are no debug sections, before .comment.

The setting of .name is really just to ensure we don't call
output_rel_find later in case no debug or .comment sections exist.
(".comment" is a good choice because we know that won't be found by
lang_output_section_find either.)

-- 
Alan Modra
Australia Development Lab, IBM

Attachment: linker-test.tgz
Description: linker-test.tgz