This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: PATCH: Handle STT_GNU_IFUNC symols when building shared library
- From: Richard Sandiford <rdsandiford at googlemail dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: binutils at sourceware dot org
- Date: Thu, 06 Jan 2011 20:59:10 +0000
- Subject: Re: PATCH: Handle STT_GNU_IFUNC symols when building shared library
- References: <20110106184700.GA21076@intel.com>
"H.J. Lu" <hongjiu.lu@intel.com> writes:
> I checked in this patch to properly handle local/global STT_GNU_IFUNC
> symols when building shared library.
I don't want to be a moaning so-and-so, but this patch touches things
outside the x86 & x86_64 backends. Did anyone approve those changes?
I ask because you've committed the patch without any real explanation.
What do you think about the point raised in 12366: that it's not really
meaningful to test def_regular in check_relocs, because the value
doesn't take into account later objects? check_relocs and the
setting of def_regular are both part of elf_link_add_object_symbols.
Richard