Re: [PATCH] AMD bdver2 processors 1/2 - BMI

[Quentin Neill <quentin dot neill dot gnu at gmail dot com>]

On Tue, Dec 28, 2010 at 8:10 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Tue, Dec 28, 2010 at 5:53 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
>> On Mon, Dec 20, 2010 at 2:55 PM, Quentin Neill
>> <quentin.neill.gnu@gmail.com> wrote:
>>> On Mon, Dec 20, 2010 at 4:39 PM, Sebastian Pop <sebpop@gmail.com> wrote:
>>>> On Mon, Dec 20, 2010 at 16:32, Quentin Neill
>>>> <quentin.neill.gnu@gmail.com> wrote:
>>>>> These two patches add support for BMI and TBM ISAs to be introduced in
>>>>> AMD bdver2 processors.
>>>>>
>>>>> The full encoding specification is delayed, however I have posted
>>>>> abbreviated specs on the gcc mailing list:
>>>>> BMI: http://gcc.gnu.org/ml/gcc-patches/2010-10/msg01766.html
>>>>> TBM: http://gcc.gnu.org/ml/gcc-patches/2010-10/msg01767.html
>>>>>
>>>>
>>>> Looks like your patch is reversed. ?Could you please send another one
>>>> that you get from git format-patch -1
>>>>
>>>> Thanks,
>>>> Sebastian
>>>
>>> Oops. ?Reposting with reversed patch. ?Thanks for reviewing Sebastian.
>>> --
>>> Quentin
>>>
>>
>> Please don't add ModrmRegExt, There are many examples in i386-opt.tbl
>> without ModrmRegExt.
>>
>>
>
> You should check i.tm.extension_opcode != None instead.
>
> --
> H.J.

Fixed with the attached.
Tested and passes with "make check RUNTESTFLAGS=i386.exp".
Okay to commit?
-- 
Quentin

Attachment: 7041_bdver2_bmi.diff.txt
Description: Text document