This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [gold patch] Fix PR gold/12220 where linker script causes internal error with compressed debug sections

From: Cary Coutant <ccoutant at google dot com>
To: Ian Lance Taylor <iant at google dot com>
Cc: Binutils <binutils at sourceware dot org>
Date: Mon, 15 Nov 2010 18:02:54 -0800
Subject: Re: [gold patch] Fix PR gold/12220 where linker script causes internal error with compressed debug sections
References: <AANLkTimRok4hqzEWzF0q0HfKBjFwV5bQJ1mc9iKf_keu@mail.gmail.com> <mcr8w0ucf2w.fsf@google.com>

> Rather than add a parameter to Layout::output_section_name, I would
> prefer to pull the is_compressed_debug_section handling into its only
> caller.

You're right, that's better. How's this? I did the .zdebug->.debug
transformation ahead of the output_section_name() transformation, and
decided that letting them compound makes sense.

-cary

        PR gold/12220
        * layout.cc (Layout::choose_output_section): Transform names of
        compressed sections even when using a script with a SECTIONS clause.
        * output.cc (Output_section::add_input_section): Use uncompressed
        section size when tracking input sections.

Attachment: gold-script-zdebug-patch.txt
Description: Text document

Follow-Ups:
- Re: [gold patch] Fix PR gold/12220 where linker script causes internal error with compressed debug sections
  - From: Ian Lance Taylor

References:
- [gold patch] Fix PR gold/12220 where linker script causes internal error with compressed debug sections
  - From: Cary Coutant
- Re: [gold patch] Fix PR gold/12220 where linker script causes internal error with compressed debug sections
  - From: Ian Lance Taylor

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]