This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFC: PATCH: PR gas/12049: Unnecessary relaxation


On Wed, Oct 27, 2010 at 08:48:07AM +1030, Alan Modra wrote:
> On Tue, Oct 26, 2010 at 07:06:24PM +0100, Dave Korn wrote:
> > On 26/10/2010 18:25, H.J. Lu wrote:
> > > On Tue, Oct 26, 2010 at 9:50 AM, Dave Korn <dave.korn.cygwin@gmail.com> wrote:
> > >>        * i386/relax-1.d: Generalize regexes a bit.
> > >>        * i386/relax-2.d: Likewise.
> 

And this for x86_64-mingw32.  Just to be different, I used .balign
this time.

	* gas/i386/x86-64-relax-1.s: Use .balign. not .align.
	* gas/i386/x86-64-relax-1.d: Remove label match, match pe output.

Index: gas/testsuite/gas/i386/x86-64-relax-1.s
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/i386/x86-64-relax-1.s,v
retrieving revision 1.1
diff -u -p -r1.1 x86-64-relax-1.s
--- gas/testsuite/gas/i386/x86-64-relax-1.s	25 Oct 2010 09:17:12 -0000	1.1
+++ gas/testsuite/gas/i386/x86-64-relax-1.s	26 Oct 2010 22:30:38 -0000
@@ -50,11 +50,11 @@
 	je	.LBB0_46
         .zero 131, 0x90
 .LBB0_46:
-	.align	16, 0x90
+	.balign	16, 0x90
 	movq	168(%rsp), %rax
         .zero 3, 0x90
 	je	.LBB1_35
-	.align	16, 0x90
+	.balign	16, 0x90
         .zero 2, 0x90
 	je	.LBB1_35
         .zero 37, 0x90
@@ -63,7 +63,7 @@
 	je	.LBB1_35
         .zero 68, 0x90
 	je	.LBB1_17
-	.align	16, 0x90
+	.balign	16, 0x90
 .LBB1_17:
         .zero 85, 0x90
 .LBB1_35:
Index: gas/testsuite/gas/i386/x86-64-relax-1.d
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/i386/x86-64-relax-1.d,v
retrieving revision 1.1
diff -u -p -r1.1 x86-64-relax-1.d
--- gas/testsuite/gas/i386/x86-64-relax-1.d	25 Oct 2010 09:17:12 -0000	1.1
+++ gas/testsuite/gas/i386/x86-64-relax-1.d	26 Oct 2010 22:30:38 -0000
@@ -6,9 +6,8 @@
 
 Disassembly of section .text:
 
-0+ <.text>:
 #...
- 358:	74 06                	je     0x360
+ 358:	74 06                	je     (0x)?360( .*)?
  35a:	66 0f 1f 44 00 00    	nopw   0x0\(%rax,%rax,1\)
  360:	90                   	nop
 #pass

-- 
Alan Modra
Australia Development Lab, IBM


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]