This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: RFC: COMDAT group names become anonymouse local symbols
On 26/10/2010 16:49, Mark Mitchell wrote:
> On 10/26/2010 12:11 PM, Dave Korn wrote:
>
>> ... breaks i686-pc-cygwin, and presumably all other COFF targets:
>
> That was the kind of testing I wanted to do, but didn't have a chance to
> do before I got on the plane.
NP :)
>> I tried changing the struct entry to 'coff_adjust_symtab' and the build
>> completes, but so would putting a null there, like in the ecoff version...
>> which is right?
>
> The former (coff_adjust_symtab) is correct. We're adding a new
> "adjust_symtab" entry to the "vtable" for object formats; the
> obj_adjust_smtab hook (as defined in the .h file for the object format)
> needs to go into the vtable.
I'll check it in shortly, thanks for getting back to me.
cheers,
DaveK