This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [gold][patch][testsuite] Fix nonexisting .c default _SOURCES


* Jan Kratochvil wrote on Sun, Oct 10, 2010 at 11:21:16PM CEST:
> On Sun, 10 Oct 2010 20:01:51 +0200, Ralf Wildenhues wrote:
> > The patch can be simplified to this line (untested):
> >   AM_DEFAULT_SOURCE_EXT = .cc
> > 
> > for all sources ending in .cc at least.
> 
> the rules are more complicated; but you are right *_SOURCES in fact should
> list the real sources, so that `make tags' index really all the files there.
> 
> There is a problem that for unsatisfied AM_CONDITIONALs the files are not
> listed for `make tags'.  But moving all the *_SOURCES definitions out of their
> conditional parts complicates it a lot.

Oh.  Are you saying there is an Automake bug involved here?

> `make tags' now lists all the persent *.{cc,c,h} files.  I did not intend to
> create such patch first.

Why are you interested at all in 'make tags' being complete for test
suite files?  They are bound to have overlapping nonunique symbol names,
and fairly uninteresting for the rest of the code, no?

> Some Makefile.in rules now contain $(CXXLINK) instead of $(LINK) but those
> rules are always overriden by Makefile.am anyway (which uses $(CXXLINK)).

Erm, if the automake-generated rules appear in Makefile.in, then they
haven't been overridden by rules from Makefile.am; automake is usually
careful to not add any generated rules for which the user has written
any herself.

Cheers,
Ralf

> gold/
> 2010-10-10  Jan Kratochvil  <jan.kratochvil@redhat.com>
> 
> 	* testsuite/Makefile.am (TAGS_FILES): New.
> 	(libgoldtest_a_SOURCES): Add test.h and testfile.h.
> 	(icf_virtual_function_folding_test_SOURCES basic_test_SOURCES)
> 	(basic_static_test_SOURCES basic_pic_test_SOURCES)
> 	(basic_static_pic_test_SOURCES basic_pie_test_SOURCES)
> 	(two_file_pie_test_SOURCES two_file_mixed_pie_test_SOURCES)
> 	(two_file_strip_test_SOURCES EXTRA_common_test_2_SOURCES): New.
> 	(weak_undef_test_SOURCES): Add weak_undef.h.
> 	(EXTRA_weak_undef_test_SOURCES EXTRA_weak_alias_test_SOURCES)
> 	(weak_plt_SOURCES EXTRA_copy_test_SOURCES tls_pie_test_SOURCES)
> 	(tls_pie_pic_test_SOURCES many_sections_r_test_SOURCES)
> 	(flagstest_o_specialfile_SOURCES)
> 	(flagstest_compress_debug_sections_SOURCES)
> 	(flagstest_o_specialfile_and_compress_debug_sections_SOURCES): New.
> 	(ver_test_SOURCES): Add ver_test.h.
> 	(EXTRA_ver_test_SOURCES EXTRA_ver_test_9_SOURCES)
> 	(EXTRA_protected_1_SOURCES EXTRA_relro_test_SOURCES)
> 	(EXTRA_justsyms_SOURCES script_test_3_SOURCES)
> 	(EXTRA_thin_archive_test_1_SOURCES plugin_test_1_SOURCES)
> 	(plugin_test_2_SOURCES plugin_test_3_SOURCES plugin_test_4_SOURCES)
> 	(plugin_test_5_SOURCES plugin_test_6_SOURCES plugin_test_7_SOURCES)
> 	(plugin_test_8_SOURCES local_labels_test_SOURCES)
> 	(permission_test_SOURCES EXTRA_searched_file_test_SOURCES)
> 	(ifuncmain1picstatic_SOURCES ifuncmain1pic_SOURCES)
> 	(ifuncmain1vispic_SOURCES ifuncmain1staticpic_SOURCES)
> 	(ifuncmain1pie_SOURCES ifuncmain1vispie_SOURCES)
> 	(ifuncmain1staticpie_SOURCES): New.
> 	(ifuncmain2static_SOURCES): Add ifunc-sel.h.
> 	(ifuncmain2picstatic_SOURCES ifuncmain2pic_SOURCES)
> 	(EXTRA_ifuncmain3_SOURCES ifuncmain4picstatic_SOURCES)
> 	(ifuncmain5picstatic_SOURCES ifuncmain5pic_SOURCES)
> 	(ifuncmain5staticpic_SOURCES ifuncmain5pie_SOURCES)
> 	(EXTRA_ifuncmain6pie_SOURCES ifuncmain7picstatic_SOURCES)
> 	(ifuncmain7pic_SOURCES ifuncmain7pie_SOURCES start_lib_test_SOURCES):
> 	New.
> 	* testsuite/Makefile.in: Regenerate.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]