This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH 11/15] MIPS/GAS/test: Add file format overrides
- From: Richard Sandiford <rdsandiford at googlemail dot com>
- To: "Maciej W. Rozycki" <macro at linux-mips dot org>
- Cc: binutils at sourceware dot org
- Date: Sun, 10 Oct 2010 11:03:49 +0100
- Subject: Re: [PATCH 11/15] MIPS/GAS/test: Add file format overrides
- References: <alpine.LFD.2.00.1010022053080.15889@eddie.linux-mips.org>
"Maciej W. Rozycki" <macro@linux-mips.org> writes:
> Ties are broken such that an architecture override takes precedence over
> a format override. This has been chosen so as to minimise the number of
> inclusions. The full sequence of test names tried is as follows:
>
> 1. arch@format@test.d
>
> 2. arch@test.d
>
> 3. format@test.d
>
> 4. test.d
This is subtle enough that it needs to be documented. How about
adding something like this after the current run_dump_test_arch comment:
# You can override the expected output for particular architectures
# and file formats. The possible test names are, in order of preference:
#
# 1. CARCH@FORMAT@NAME.d
# 2. CARCH@NAME.d
# 3. FORMAT@NAME.d
# 4. NAME.d
#
# where CARCH is the "canonical" name of architecture ARCH and where
# FORMAT is the target's file format ("elf", "ecoff" or "aout").
> 2010-10-03 Maciej W. Rozycki <macro@linux-mips.org>
>
> gas/testsuite/
> * gas/mips/mips.exp (run_dump_test_arch): Check for the presence
> of a file-format-specific test too.
> (run_dump_test_arches): Pull elf, ecoff and aout variables for use
> by the above.
OK with that change, thanks.
Richard