This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 11/15] MIPS/GAS/test: Add file format overrides


"Maciej W. Rozycki" <macro@linux-mips.org> writes:
>  Ties are broken such that an architecture override takes precedence over 
> a format override.  This has been chosen so as to minimise the number of 
> inclusions.  The full sequence of test names tried is as follows:
>
> 1. arch@format@test.d
>
> 2. arch@test.d
>
> 3. format@test.d
>
> 4. test.d

This is subtle enough that it needs to be documented.  How about
adding something like this after the current run_dump_test_arch comment:

# You can override the expected output for particular architectures
# and file formats.  The possible test names are, in order of preference:
#
# 1. CARCH@FORMAT@NAME.d
# 2. CARCH@NAME.d
# 3. FORMAT@NAME.d
# 4. NAME.d
#
# where CARCH is the "canonical" name of architecture ARCH and where
# FORMAT is the target's file format ("elf", "ecoff" or "aout").

> 2010-10-03  Maciej W. Rozycki  <macro@linux-mips.org>
>
> 	gas/testsuite/
> 	* gas/mips/mips.exp (run_dump_test_arch): Check for the presence
> 	of a file-format-specific test too.
> 	(run_dump_test_arches): Pull elf, ecoff and aout variables for use 
> 	by the above.

OK with that change, thanks.

Richard


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]