This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] Add plugin interface to LD [4/4] Add files, libs and dir paths.
- From: Richard Henderson <rth at redhat dot com>
- To: Dave Korn <dave dot korn dot cygwin at gmail dot com>
- Cc: "binutils at sourceware dot org" <binutils at sourceware dot org>
- Date: Wed, 06 Oct 2010 15:40:15 -0700
- Subject: Re: [PATCH] Add plugin interface to LD [4/4] Add files, libs and dir paths.
- References: <4C9AE5CA.80707@gmail.com> <4C9AE65D.5000201@gmail.com>
On 09/22/2010 10:32 PM, Dave Korn wrote:
> +#ifdef ENABLE_PLUGINS
> + union lang_statement_union **listend;
> +#endif /* ENABLE_PLUGINS */
...
> #ifdef ENABLE_PLUGINS
> /* Now all files are read, let the plugin(s) decide if there
> are any more to be added to the link before we call the
> emulation's after_open hook. */
> + listend = statement_list.tail;
> + ASSERT (!*listend);
Better to merge these two with a set of braces inside
the second ENABLE_PLUGINS ifdef.
> + osec = osec;
> + oval = oval;
Please just use ATTRIBUTE_UNUSED.
Otherwise ok.
r~