This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: Fix MIPS multi-GOT -Bsymbolic link failure
On Sat, Aug 28, 2010 at 06:24:52PM +0100, Richard Sandiford wrote:
> Richard Sandiford <rdsandiford@googlemail.com> writes:
> > I might also experiment with generating local GOT entries in this
> > case, as mentioned before.
>
> Here's what I had in mind. It means we use local relocations for all
> GOT entries in Joseph's testcase, which should be a little more
> efficient at load time.
>
> Tested against the binutils testsuite on mips64-linux-gnu, and by
> building and testing GCC on the same target. I'll commit it in
> a couple of days if there are no objections.
Fabulous!
To answer an implied question in your previous message, I was happy
with Joseph's patch - but I'm just as happy with this one. I've spent
a lot of time in the MIPS GOT code, and I lean towards things that I
can convince myself are safe, which is a pretty small set :-) But
your patch removes several things that seem fragile and I like the
replacements.
--
Daniel Jacobowitz
CodeSourcery