This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [Patch/PE_COFF] Make auto-import/merge-rdata defaults same for all *.*.mingw*
- From: Kai Tietz <ktietz70 at googlemail dot com>
- To: Danny Smith <dansmister at gmail dot com>
- Cc: binutils at sourceware dot org, Dave Korn <dave dot korn dot cygwin at gmail dot com>
- Date: Mon, 14 Jun 2010 23:57:36 +0200
- Subject: Re: [Patch/PE_COFF] Make auto-import/merge-rdata defaults same for all *.*.mingw*
- References: <AANLkTik0cfqADy18ZbckQiZA5uzhSqIUFZvfVmVut8uf@mail.gmail.com>
Hi Danny,
2010/6/14 Danny Smith <dansmister@gmail.com>:
> This makes the mingw.org toolchain have the same auto-import defaults
> as the w64-mingw ?toolchain.
>
> Tested on i686-pc-mingw32 and ix86_64-w64-mingw32.
>
> OK to commit?
>
> ChangeLog
>
> 20210-06-15 ?Danny Smith ?<dannysmith@users.sourceforge.net>
>
> ? ? ?* emultempl/pe.em (gld_${EMULATION_NAME}_before_parse): Make
> ? ? ?auto-import/merge-rdata defaults same for all ?*.*.mingw*
>
>
> Index: emultempl/pe.em
> ===================================================================
> RCS file: /cvs/src/src/ld/emultempl/pe.em,v
> retrieving revision 1.160
> diff -u -r1.160 pe.em
> --- emultempl/pe.em ? ? 25 May 2010 10:00:25 -0000 ? ? ?1.160
> +++ emultempl/pe.em ? ? 14 Jun 2010 21:09:49 -0000
> @@ -174,7 +174,7 @@
> ? ? default_auto_import=1
> ? ? default_merge_rdata=1
> ? ? ;;
> - ?*-w64-mingw*)
> + ?*-*-mingw*)
> ? ? default_auto_import=1
> ? ? default_merge_rdata=0
> ? ? ;;
>
wouldn't it be better to enable it just for x86_64 and i?86 mingw
targets? AFAIR aren't all mingw targets able to support v2 relocation
at the moment.
But well, as the rdata-merge gets active just for v2, it shouldn't matter.
Kai
--
| (\_/) This is Bunny. Copy and paste
| (='.'=) Bunny into your signature to help
| (")_(") him gain world domination