This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] fix shadowed variable i when DEBUG386 is on

From: Sebastian Pop <sebpop at gmail dot com>
To: "H.J. Lu" <hjl dot tools at gmail dot com>
Cc: Quentin Neill <quentin dot neill dot gnu at gmail dot com>, binutils at sourceware dot org
Date: Tue, 8 Jun 2010 10:43:00 -0500
Subject: Re: [PATCH] fix shadowed variable i when DEBUG386 is on
References: <AANLkTiltJUmr8zNDdeNtJBjASFYXygSagFHYFKg65M0P@mail.gmail.com> <AANLkTilYmE60Y7cLx5A8Fm3_bNd9eIlpInvrfl4GsvMo@mail.gmail.com>

On Mon, Jun 7, 2010 at 17:04, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Mon, Jun 7, 2010 at 2:56 PM, Quentin Neill
> <quentin.neill.gnu@gmail.com> wrote:
>> When building i386 assembler with -DDEBUG386 we get:
>> config/tc-i386.c: In function 'pi':
>> config/tc-i386.c:2344: error: declaration of 'i' shadows a global declaration
>> config/tc-i386.c:365: error: shadowed declaration is here
>>
>> This fix renames it to j. ?Tested with "make check" on x86. ?Okay to commit?
>>
>> gas:
>> ? ?* config/tc-i386.c (pi): Rename local loop counter
>> ? ?variable i that shadows global static i386_insn i
>> ? ?when DEBUG386 is defined.
>> ? ?(pte) Ditto.
>>
>
> OK.

Committed.

References:
- [PATCH] fix shadowed variable i when DEBUG386 is on
  - From: Quentin Neill
- Re: [PATCH] fix shadowed variable i when DEBUG386 is on
  - From: H.J. Lu

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]