This is the mail archive of the
mailing list for the binutils project.
Re: Gold Patch to fix ICF bug.
Sriraman Tallam <email@example.com> writes:
>> When I look at this test I don't understand what it is testing. ÂIt
>> seems like the program is always going to run successfully, and you
>> aren't testing anything else here. ÂWhat is the point of this test?
> In this test, fn1 is folded into fn2 but still the linker must
> generate a dynamic relocation for the vtable entry for fn1 as it is a
> pie executable and fn1 is virtual. Otherwise, the program segfaults. I
> am simply testing this. Is this alright ? I had
> icf_virtual_function_folding_test run using a shell script before and
> I realized that was not necessary.
If it segfaults before your patch and stops segfaulting after your
patch then this test is fine. I guess I don't yet see why it
segfaults before your patch, but I haven't tried running it myself.