This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [Patch]: upgrade to automake 1.11.1
* Jim Meyering wrote on Wed, Mar 31, 2010 at 05:17:24PM CEST:
> Ralf Wildenhues wrote:
> > I'd call gnu.org having a too-strict rule an administrative issue.
>
> Distributing code built with unpatched automake is normally
> serious enough that I feel the current upload-check is appropriate.
> However, if there are more projects like binutils that use the no-dist
> option, and they can demonstrate that upgrading is not feasible
> (I'd be surprised), then it may well make sense to relax it to
> accommodate them.
I guess upgrading old release branches could be a problem. The upgrade
from 1.9.6 to 1.11 was nontrivial for binutils, and Autoconf would need
updating, too. I guess if that's really necessary to do for GCC, then
I'd rather release an 1.9.7 with the security fix applied.
> Hmm... I tried using no-dist, and the resulting Makefile
> contains no distdir rule at all, so I can't see how it would
> trigger the check.
Oops. gold/Makefile.am uses neither no-dist nor cygnus options.
Sorry about the false alarm then.
So, maybe the right thing to do for old GCC branches is to add no-dist
to all offending configure.ac/Makefile.am files.
> Perhaps this is a feature new to automake-1.11a, and your 1.11
> does not elide the distdir rule when no-dist is used.
no-dist is very old.
> Or you have a subdir-project which *does* have an offending
> dist-related rule.
Yep.
Tristan, you shouldn't have to update binutils to 1.11.1 with the patch
below, and even if you did already, the patch below is a useful size
reduction. OK to commit? (Tested by running 'make' and by inspection
of the Makefile.in diff.)
Thanks,
Ralf
Use Automake option no-dist in gold
gold/ChangeLog:
2010-03-31 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
* Makefile.am (AUTOMAKE_OPTIONS): Add no-dist.
* Makefile.in: Regenerate.
diff --git a/gold/Makefile.am b/gold/Makefile.am
index e0665e0..f50d7ff 100644
--- a/gold/Makefile.am
+++ b/gold/Makefile.am
@@ -1,6 +1,6 @@
# Process this file with automake to generate Makefile.in
-AUTOMAKE_OPTIONS = foreign
+AUTOMAKE_OPTIONS = foreign no-dist
SUBDIRS = po testsuite