Re: [RFA] Add a test case for PR ld/11304

[Jie Zhang <jie at codesourcery dot com>]

On 03/19/2010 08:52 PM, Daniel Jacobowitz wrote:
> On Wed, Mar 17, 2010 at 07:44:09PM +0800, Jie Zhang wrote:
> > This patch tries to add a test case for PR ld/11304 so we can catch
> > the future regression. To help write the test case, I add a new
> > #-comment "#failif". This new #-comment is used to specify that the
> > test passes iff when the result does *not* match the regular
> > expressions. It is required to be placed before the regular
> > expressions, as this new test does. Regression tested on
> > i686-pc-linux-gnu. Is it OK?
>
> Yes, this is OK.  Thanks!
>
> > 	PR ld/11304
> > 	* ld-elf/{pr11304.d, pr11304a.s, pr11304b.s}: New test.
>
> But please don't abbreviate files in the changelog entry, just list
> them all.
Thanks. Committed with the following ChangeLog entry.

        PR ld/11304
        * ld-elf/pr11304.d: New test.
        * ld-elf/pr11304a.s: New test.
        * ld-elf/pr11304b.s: New test.
        * lib/ld-lib.exp (regexp_diff): Add support for #failif.

--
Jie Zhang
CodeSourcery
(650) 331-3385 x735