This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: PATCH: Support VER_FLG_INFO in readelf
- From: Ian Lance Taylor <iant at google dot com>
- To: Rainer Orth <ro at CeBiTec dot Uni-Bielefeld dot DE>
- Cc: binutils at sourceware dot org
- Date: Tue, 02 Mar 2010 07:40:37 -0800
- Subject: Re: PATCH: Support VER_FLG_INFO in readelf
- References: <yddiq9fzo9f.fsf@manam.CeBiTec.Uni-Bielefeld.DE>
Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> writes:
> 2010-02-27 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
>
> include:
> * elf/common.h (VER_FLG_INFO): Define.
>
> gold:
> * dynobj.h (Verdef::Verdef): Add is_info arg, is_info member
> function, is_info_ member.
> * dynobj.cc (Verdef::write): Set VER_FLG_INFO if this->is_info_.
> (Versions::Versions): Update caller.
> (Versions::define_base_version): Likewise.
> (Versions::add_def): Likewise.
>
> elfcpp:
> * elfcpp.h (VER_FLG_INFO): Define.
>
> binutils:
> * readelf.c (get_ver_flags): Handle VER_FLG_INFO.
I suppose the changes to elfcpp and gold are OK. They seem kind of
useless, though, since the is_info_ field will never be set to true.
What would you expect to cause that field to be true?
Please do verify that the code compiles before committing it.
Thanks.
Ian