Re: [committed] Re: Unexpected passes!

[Kai Tietz <ktietz70 at googlemail dot com>]

Hello Dave and NightStrike,

2010/1/30 Dave Korn <dave.korn.cygwin@googlemail.com>:
> On 30/01/2010 06:53, NightStrike wrote:
>> I ran the binutils testsuite using binutils HEAD on cygwin as a cross
>> compiler to x86_64-w64-mingw32, and I received the following XPASS's!
>> Who can update them?
>>
>> Running /tmp/mw64/build/binutils/src/binutils/testsuite/binutils-all/windres/windres.exp
>> ...
>> XPASS: windres/html (parse)
>> XPASS: windres/html (compare)
>> XPASS: windres/lang (parse)
>> XPASS: windres/lang (compare)
>> XPASS: windres/messagetable (parse)
>> XPASS: windres/messagetable (compare)
>> XPASS: windres/strtab1 (parse)
>> XPASS: windres/strtab1 (compare)
>> XPASS: windres/strtab2 (parse)
>> XPASS: windres/strtab2 (compare)
>> XPASS: windres/version (parse)
>> XPASS: windres/version (compare)
>> XPASS: windres/version_cat (parse)
>> XPASS: windres/version_cat (compare)
>
> ?I saw those too, in my test results when checking the coff section alignment
> extension I just added. ?I've committed the attached to HEAD.
>
> binutils/testsuite/ChangeLog:
>
> ? ? ? ?* binutils-all/windres/html.rc: Don't xfail x86_64-*-mingw*.
> ? ? ? ?* binutils-all/windres/lang.rc: Likewise.
> ? ? ? ?* binutils-all/windres/messagetable.rc: Likewise.
> ? ? ? ?* binutils-all/windres/strtab1.rc: Likewise.
> ? ? ? ?* binutils-all/windres/strtab2.rc: Likewise.
> ? ? ? ?* binutils-all/windres/version.rc: Likewise.
> ? ? ? ?* binutils-all/windres/version_cat.rc: Likewise.

Thanks for fixing this. This is a remaining from initial port of
binutils for x64 windows. At this time it was unlikely to have while
gcc build already a working windows preprocessor.
AFAIR those test will still fail on none-windows host, if it doesn't
has a windows gcc pre-installed. That was the reason not to fix them.
Anyway thanks for the fix.

Kai

-- 
|  (\_/) This is Bunny. Copy and paste
| (='.'=) Bunny into your signature to help
| (")_(") him gain world domination