This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH][GOLD] Build Cortex-A8 stubs.
Hi
2010/1/13 Ian Lance Taylor <iant@google.com>:
> The comment is correct, so unless you have an upcoming patch to fix
> this, I think you should add something like
> ?gold_assert (!os->requires_postprocessing());
>
Copy and pasted error. Will remove comment.
>> + ? ? ?gold_warning(_("Cortex-A8 erratum scanning failed because there "
>> + ? ? ? ? ? ? ? ? ?"is no mapping symbols for section %u of %s."),
>> + ? ? ? ? ? ? ? ?shndx, this->name().c_str());
>
> No period at the end of an error or warning. ?Also errors and warnings
> don't start with capital letters, but it's OK if the name is normally
> capitalized.
>
Ok. Name is capitalized throughout the file.
Thanks for the quick review.
-Doug
> This is OK with those changes.
>
> Thanks.
>
> Ian
>