This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH][GOLD] Attributes section part 2
"Doug Kwan (éæå)" <dougkwan@google.com> writes:
> 2009-12-07 Doug Kwan <dougkwan@google.com>
>
> * Makefile.am (CCFILES): Add attributes.cc and int_encoding.cc.
> (HFILES): Add attributes.h and int_encoding.h.
> * Makefile.in: Regenerate.
> * dwarf_reader.cc (read_unsigned_LEB_128, read_signed_LEB_128): Move
> function definitions to int_encoding.cc
> * dwarf_reader.h (read_unsigned_LEB_128, read_signed_LEB_128): Move
> prototypes to int_encoding.h
> * reduced_debug_output.cc (int_encoding.h): New include.
> (write_unsigned_LEB_128, get_length_as_unsigned_LEB_128): Move
> function definitions to int_encoding.cc
> (insert_into_vector, read_from_pointer): Move template definitions to
> int_encoding.h
> * attributes.cc: New file.
> * attributes.h: New file.
> * int_encoding.cc: New file.
> * int_encoding.h: New file.
> RCS file: gold/attributes.cc
> diff -N gold/attributes.cc
> --- /dev/null 1 Jan 1970 00:00:00 -0000
> +++ gold/attributes.cc 8 Dec 2009 01:54:52 -0000
> @@ -0,0 +1,458 @@
> +// attributes.cc -- object attributes for gold
> +
> +// Copyright 2009 Free Software Foundation, Inc.
> +// Written by Doug Kwan <dougkwan@google.com>.
> +// This file contains code adapted from bfd
s/bfd/BFD./ (note added period).
> +// attributes.h -- object attributes for gold -*- C++ -*-
> +
> +// Copyright 2009 Free Software Foundation, Inc.
> +// Written by Doug Kwan <dougkwan@google.com>.
> +// This file contains code adapted from bfd
Same here.
> +// This classs contains attributes of a particular vendor.
s/classs/class/
> +//
> +// unaligned integer encoding support.
> +//
s/unaligned/Unaligned/.
> +// insert VALSIZE-bit integer VALUE into DESTINATION.
s/insert/Insert/.
This is OK with those comment changes.
Thanks.
Ian