This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [Patch]: ld crash on i386/pe when linking with a dll that has no exports
On Nov 27, 2009, at 3:59 PM, Dave Korn wrote:
> Tristan Gingold wrote:
>> On Nov 27, 2009, at 3:40 PM, Dave Korn wrote:
>>
>>> Tristan Gingold wrote:
>>>
>>>> Ok, here is what I am checking. I think that comments are clarified.
>>>>
>>>> (Note: I think that the number of directory entries is always 16. But
>>>> the check is harmless).
>>> The number of directory entries is *usually* 16, but the spec explicitly
>>> allows it to be greater or fewer and warns that you must always validate
>>> everything against the header size and number of directory entries. So
>>> the check is definitely required and not just mostly harmless.
>>
>> We then should be more careful in peXXigen.c because it always reads and
>> converts 16 entries ;-)
>
> Thanks for the notice, I'll stick it on my to-do list. (I plan to give the
> PE DLL code a thorough shakedown and maintenance once I'm finished with gcc
> 4.5 stuff, sometime toward late December most likely.)
Great!
Tristan.