This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch]: fix bfd/targets.c build failure on AIX


On Nov 17, 2009, at 1:20 PM, Alan Modra wrote:

> On Tue, Nov 17, 2009 at 11:57:58AM +0100, Tristan Gingold wrote:
>> 
>> On Nov 17, 2009, at 11:32 AM, Nick Clifton wrote:
>> 
>>> Hi Tristan,
>>> 
>>>> 2009-11-17  Tristan Gingold  <gingold@adacore.com>
>>>> 	* targets.c: Include alloc-conf.h
>>> 
>>> Approved - please apply.
>> 
>> Thanks, committed.
> 
> This is wrong.  alloca should not be used in libbfd, and where we
> grudgingly accept it, alloca-conf.h needs to be the first include
> file.

So, do we accept alloca in targets.c ?  That will determine the next patch.
Maybe we should also clearly document in alloca-conf.h that this file must be the first include.

The uses of alloca is xsym.c and som.c could be easily removed.  Will work on it.

Tristan.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]