This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch ARM] Prevent disassembler from aborting on an invalid Thumb2 instruction.


On Tue, 2009-11-17 at 10:27 +0000, Ramana Radhakrishnan wrote:
> Hi, 
> 
> Ed Nevill discovered this and proposed the attached patch while debugging some code. The disassembler aborts when faced with an 
> invalid instruction in Thumb2 state. 
> 
> The testcase is as simple as the following. 
> 
>         .cpu cortex-a8
>         .syntax unified
>         .thumb
>         .global main
>         .type main,%function
> main:
>         .inst.w 0xe81c0c20
> 
> Without this patch objdump aborts - with this patch objdump prints out something more sensible like : 
> 
> Disassembly of section .text:
> 
> 00000000 <main>:
>    0:   e81c 0c20       undefined instruction 0xe81c0c20
> 
> Tested cross with arm-none-eabi with no regressions. Ok to commit ? 
> 
> cheers
> Ramana
> 

OK

R.



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]