This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: [GAS] [PATCH] Added support for the ARM VMSR and VMRS instructions

Thanks, Nick, for reviewing the patch.

Please find attached the updated patch.

* Literal 15 changed to REG_PC and added comment about APSR_nzcv encoding.
* Fixed comment formatting.
* Added unit tests to gas/testsuite/gas/arm/vfp1xD.s and vfp1xD.d to check the assembly of the vmsr and vmrs instructions.

Cheers,
Viktor.

________________________________________
From: Nick Clifton [nickc@redhat.com]
Sent: Thursday, November 12, 2009 2:03 AM
To: Viktor Kutuzov
Cc: binutils@sourceware.org
Subject: Re: [GAS] [PATCH] Added support for the ARM VMSR and VMRS instructions

Hi Viktor,

> Attached is a patch that adds a support for the ARM VMSR and VMRS
> instructions.

The patch is mostly OK, but there are a few issues:

   --- gas/config/tc-arm.c      3 Nov 2009 12:37:44 -0000       1.413
   +++ gas/config/tc-arm.c      11 Nov 2009 02:22:49 -0000
   @@ -6303,6 +6395,7 @@
                  if (found != 15)
                    goto failure;
                  inst.operands[i].isvec = 1;
   +          inst.operands[i].reg = 15;
                }
              else
                goto failure;

What is the purpose of this change ?


   +  /* APSR_ sets isvec. All other refs to PC are illegal */

Comment formatting.  Should end:  illegal.  */


One other point.  Please could you add a couple of lines to
gas/testsuite/gas/arm/vfp1xD.s and vfp1xD.d to check the assembly of the
vmsr and vmrs instructions ?

Cheers
   Nick

Attachment: binutils-gas-vmrs-vmsr-2.diff
Description: binutils-gas-vmrs-vmsr-2.diff

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]