This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: PATCH: Add a testcase for PR 876
On Wed, Nov 4, 2009 at 6:37 PM, Hans-Peter Nilsson
<hans-peter.nilsson@axis.com> wrote:
>> Date: Wed, 4 Nov 2009 10:49:34 -0800
>> From: "H.J. Lu" <hongjiu.lu@intel.com>
>
>> Index: gas/i386/i386.exp
>> ===================================================================
>> --- gas/i386/i386.exp (revision 7236)
>> +++ gas/i386/i386.exp (working copy)
>> @@ -17,6 +17,9 @@ proc gas_32_check { } {
>> ? ? ?return [regexp "targets:.*i386" [lindex $status 1]];
>> ?}
>>
>> +# Common tests
>> +run_list_test "space1" "-al"
>> +
>> ?if [expr ([istarget "i*86-*-*"] || ?[istarget "x86_64-*-*"]) && [gas_32_check]] ?then {
>
> This is wrong, you've put the test before the target-gate-test,
> so it's attempted on all targets, not just the x86 and
> relatives.
>
I will fix it tomorrow.
--
H.J.