This is the mail archive of the mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC] extending bfd_print_private_bfd_data

On Nov 4, 2009, at 4:25 PM, Dave Korn wrote:

Tristan Gingold wrote:

On Nov 4, 2009, at 4:05 PM, Dave Korn wrote:

As long as you're going to the lengths of accepting a list of names
from the
backend and parsing them all and passing them back one at a time to the
backend, why not go that little way further and build a word full of
flag bits
instead? It would save all the bfd_print_private_bfd_data routines from
filling up with lots of ugly strcmps if they could just check a bitmask.

This requires table to translate names to flag bits. But I am not sure
that this is easy to do because
some print_private_bfd_data calls a more generic version of it (eg: elf).
Maybe you have a nice idea to implement such a table ?

I figured that there could be just a very simple convention: assign
successive flag bits starting at 0 to successive words in the string of -P
subtype names that the backend returns. So maybe in the PE backend we'd write
(completely made-up example with just realistic-sounding names):



and that would be that; it probably would be easy enough to maintain that it
wouldn't even justify the effort of using a .def file and some macro trickery
to generate both the string and flag definitions from the same single list of

I can't figure out exactly how this would work with elf backends. See for example elf32-m32c.c:

m32c_elf_print_private_bfd_data (bfd *abfd, PTR ptr)
  FILE *file = (FILE *) ptr;
  flagword flags;

BFD_ASSERT (abfd != NULL && ptr != NULL);

  /* Print normal ELF private data.  */
  _bfd_elf_print_private_bfd_data (abfd, ptr);


In this case, the complete words string would be a concatenation of the one for _bfd_elf_print_private_bfd_data and the one for m32c.
But the flag value for m32c would depend on the number of words for the elf generic printer. Doable but
more cryptic IMHO.

Or were you planning that some backends might dynamically generate their
list of words?

No I don't plan that.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]