This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [GOLD][PATCH] Set ARM ABI information in ELF file header.
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: =?big5?b?RG91ZyBLd2FuICjD9q62vHcp?= <dougkwan at google dot com>
- Cc: Ian Lance Taylor <iant at google dot com>, binutils <binutils at sourceware dot org>, Viktor Kutuzov <vkutuzov at accesssoftek dot com>
- Date: Tue, 27 Oct 2009 13:04:25 +0000 (UTC)
- Subject: Re: [GOLD][PATCH] Set ARM ABI information in ELF file header.
- References: <498552560910261832i6aed073ei43ba2aa5dd6e9823@mail.gmail.com>
On Mon, 26 Oct 2009, Doug Kwan (Ãö®¶¼w) wrote:
> Hi,
>
> This patch adds code to set proper flags in the processor-specific
> flags in the ELF file header. Previously we always set e_flags to 0
> on all target. This patch add methods processor_specific_flags and
> set_processor_specific_flags in Target so that Output_file_header can
> get the flags. For targets that merge processor-specific flags from
> input objects, we also track whether the flags have been set at least
> once. Currently only the ARM target sets the flags correctly.
It looks like this patch is replicating the GNU ld bug whereby
EF_ARM_HASENTRY is set on EABI objects. There is no such flag in AAELF
and so it is a bug to set it on such objects.
--
Joseph S. Myers
joseph@codesourcery.com