This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch include]: Fix warnings


2009/9/25 Nick Clifton <nickc@redhat.com>:
> Hi Kai,
>
>> this patch fixes warnings about the use of long long, when cX9
>> standards are used, by prefixing typedef by __extension__.
>
>> - ?typedef unsigned long long libi_uhostptr_t;
>> - ?typedef long long libi_shostptr_t;
>> + ?__extension__ typedef unsigned long long libi_uhostptr_t;
>> + ?__extension__ typedef long long libi_shostptr_t;
>
> This would work providing that you are always compiling with a recent
> version of gcc or that you have included ansidecl.h before splay-tree.h, but
> that cannot be guaranteed. ?I would suggest adding a check for gcc as well,
> eg:
>
> ?#ifdef __GNUC__
> ?__extension__
> ?#endif
> ?typedef unsigned long long lib_uhostptr_t;
>
> Cheers
> ?Nick
>
>

Ok, here is the updated patch. Ok for apply?

Cheers,
Kai

-- 
|  (\_/) This is Bunny. Copy and paste
| (='.'=) Bunny into your signature to help
| (")_(") him gain world domination

Attachment: f_splaytree.diff
Description: Binary data


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]