This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [GOLD][PATCH] A stub table class for ARM stubs.
- From: Ian Lance Taylor <iant at google dot com>
- To: Doug Kwan (éæå) <dougkwan at google dot com>
- Cc: binutils <binutils at sourceware dot org>
- Date: Wed, 21 Oct 2009 07:02:03 -0700
- Subject: Re: [GOLD][PATCH] A stub table class for ARM stubs.
- References: <498552560910210206i37cf8001k20e62f51962457bc@mail.gmail.com>
"Doug Kwan (éæå)" <dougkwan@google.com> writes:
> 009-10-21 Doug Kwan <dougkwan@google.com>
>
> * arm.cc (Stub_table, Arm_input_section): New forward class
> declarations.
> (Stub_table): New class defintion.
> (Stub_table::add_reloc_stub, Stub_table::relocate_stubs
> Stub_table::do_reset_address_and_file_offset, Stub_table::do_write):
> New method definitions.
> + for(typename Reloc_stub_map::const_iterator p = this->reloc_stubs_.begin();
> + p != this->reloc_stubs_.end();
> + ++p)
s/for(/for (/
> + for(typename Reloc_stub_map::const_iterator p = this->reloc_stubs_.begin();
> + p != this->reloc_stubs_.end();
> + ++p)
s/for(/for (/
> + {
> + Reloc_stub* stub = p->second;
> + const Stub_template* stub_template = stub->stub_template();
> + uint64_t stub_addralign = stub_template->alignment();
> + max_addralign = std::max(max_addralign, stub_addralign);
To use std::max you should #include <algorithm> up by #include
<string>.
> + for(typename Reloc_stub_map::const_iterator p = this->reloc_stubs_.begin();
> + p != this->reloc_stubs_.end();
> + ++p)
s/for(/for (/
This is OK with those changes.
Thanks.
Ian