This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Use enum instead of nested macros in i386-opc.h


H.J. Lu wrote:
[...]
+enum
+{
+  /* i186 or better required */
+  Cpu186 = 0,
[...]
+enum
+{
+  /* has direction bit. */
+  D = 0,
[...]
+enum
+{
+  /* 8bit register */
+  Reg8 = 0,

Putting on my pedant's hat: All those '= 0' are redundant.


David Daney


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]