This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: PATCH: Use enum instead of nested macros

From: David Daney <ddaney at caviumnetworks dot com>
To: "H.J. Lu" <hjl dot tools at gmail dot com>
Cc: binutils at sources dot redhat dot com
Date: Thu, 15 Oct 2009 16:46:31 -0700
Subject: Re: PATCH: Use enum instead of nested macros
References: <20091015224902.GA2045@lucon.org>

H.J. Lu wrote:

I am checking in this patch to use enum instead of nested macros.

[...]

+enum
+{
+  REG_80 = 0,
+  REG_81 = REG_80 + 1,
+  REG_82 = REG_81 + 1,

Am I missing something, or is every single one of your ' = foo + 1' in this patch completely redundant?

If they are in fact redundant, why have them?

David Daney

Follow-Ups:
- Re: PATCH: Use enum instead of nested macros
  - From: H.J. Lu

References:
- PATCH: Use enum instead of nested macros
  - From: H.J. Lu

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]