This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] Gold: Added R_ARM_GOT_PREL relocation and unit tests
- From: Ian Lance Taylor <iant at google dot com>
- To: Viktor Kutuzov <vkutuzov at accesssoftek dot com>
- Cc: <binutils at sourceware dot org>
- Date: Wed, 07 Oct 2009 08:31:29 -0700
- Subject: Re: [PATCH] Gold: Added R_ARM_GOT_PREL relocation and unit tests
- References: <7ebec9e70908130809n1eadef26o479906b6e228caea@mail.gmail.com> <33D126FC21A4401492D88E8D464241C7@andreic6e7fe55> <m3prabpjnt.fsf@google.com> <8AF7C7F590364AA8ABA06F51EC5E0478@andreic6e7fe55> <m3my5emk9n.fsf@google.com> <DFB1B4C0C31647EFBF45F1199BB66A3D@andreic6e7fe55> <C785DF9E73CB4DB487F8AB66740305D7@andreic6e7fe55>
Viktor Kutuzov <vkutuzov@accesssoftek.com> writes:
> Please find attached the patch for R_ARM_GOT_PREL relocation along with the unit tests.
>
> Best regards,
> Viktor
>
> * gold/arm.cc: Added R_ARM_GOT_PREL relocation, added missing R_ARM_ABS8 in to the list of implemented relocations
> * gold/testsuite/arm/Makefile.am: Added unit tests to make
> * gold/testsuite/arm/reloc_got_test.sh: Script to test platform-dependent R_ARM_GOT_PREL relocation
> * gold/testsuite/arm/arm_r_got_prel.s: Asm for the R_ARM_GOT_PREL relocation unit tests
I approved and committed your patch to arm.cc with the following
ChangeLog entry. I did not commit the patch to the testsuite, pending
further work on the testsuite.
Thanks, and sorry for the long delay.
Ian
2009-10-07 Viktor Kutuzov <vkutuzov@accesssoftek.com>
* arm.cc (Arm_relocate_functions::got_prel) New function.
(Scan::local, Scan::global): Handle R_ARM_GOT_PREL.
(Relocate::relocate): Likewise.
(Relocatable_size_for_reloc::get_size_for_reloc): Likewise.