This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] Add support for .cfi_sections - way to emit also .debug_frame from .cfi_* directives
On Thu, Oct 01, 2009 at 10:58:00PM +0200, Jakub Jelinek wrote:
> Like this?
>
> 2009-10-01 Jakub Jelinek <jakub@redhat.com>
>
> * dw2gencfi.c: Include dwarf2dbg.h.
> (DWARF2_FORMAT): Define if not defined.
> (dot_cfi_sections): New function.
> (cfi_pseudo_table): Handle .cfi_sections.
> (CFI_EMIT_eh_frame, CFI_EMIT_debug_frame): Define.
> (cfi_sections): New variable.
> (output_cie, output_fde, select_cie_for_fde): Add eh_frame
> argument, add supporting for outputting .debug_frame
> section.
> (cfi_change_reg_numbers): New function or macro.
> (cfi_finish): Only emit .eh_frame if
> cfi_sections & CFI_EMIT_eh_frame. Emit .debug_frame if
> cfi_sections & CFI_EMIT_debug_frame.
> * config/tc-ppc.h (md_reg_eh_frame_to_debug_frame): Define.
> * doc/as.texinfo (CFI directives): Document .cfi_sections.
Thanks. Looks fine to me, but I'd rather give other maintainers a day
to comment.
Is it going to be a problem that DWARF2_FORMAT is defined to 32bit by
default on everything but MIPS? In general, I've noticed that GCC has
lots of knobs to tweak DWARF-2 generation; by pushing the generation
off to gas without propogating those knobs (e.g. what encodings to
use), we're causing a bunch of new bugs.
--
Daniel Jacobowitz
CodeSourcery