Re: [PATCH][GOLD] Add -z nocopyreloc option.

[=?big5?b?RG91ZyBLd2FuICjD9q62vHcp?= <dougkwan at google dot com>]

Thanks for the good suggestions.  Here is the updated patch.

-Doug

2009-09-30  Doug Kwan  <dougkwan@google.com>

        * arm.cc (Target_arm::may_need_copy_reloc): Check for THUMB function
        symbol and call Symbol::may_need_copy_reloc to determine if
        a copy reloc is needed.
        * copy-relocs.cc (Copy_relocs::need_copy_reloc): Return false if -z
        nocopyreloc is given in command line.
        (Copy_relocs::emit_copy_reloc): Assert that -z nocopyreloc is not
        given in command line.
        * i386.cc (Target_i386::may_need_copy_reloc): Remove.
        (Target_i386::Scan::global): Use Symbol::may_need_copy_reloc instead
        of the removed Target_i386::may_need_copy_reloc.
        * options.h (copyreloc): New option with default value false.
        * powerpc.cc (Target_powerpc::may_need_copy_reloc): Remove.
        (Target_powerpc::Scan::global): Use Symbol::may_need_copy_reloc
        instead of the removed Target_powerpc::may_need_copy_reloc.
        * sparc.cc (Target_powerpc::may_need_copy_reloc): Remove.
        (Target_sparc::Scan::global): Use Symbol::may_need_copy_reloc
        instead of the removed Target_sparc::may_need_copy_reloc.
        * symtab.h (Symbol::may_need_copy_reloc): New method definition.
        * x86_64.cc (Target_powerpc::may_need_copy_reloc): Remove.
        (Target_x86_64::Scan::global): Use Symbol::may_need_copy_reloc
        instead of the removed Target_x86_64::may_need_copy_reloc.


2009/9/30 Ian Lance Taylor <iant@google.com>:
> "Doug Kwan (Ãö®¶¼w)" <dougkwan@google.com> writes:
>
>>     This patch added a -z nocopyreloc option for compatiblity with ld.
>>  Tested on x86_64 with no regression.
>
> Please instead add an option -z copyreloc, with an appropriate
> nohelpstring argument.  You will get the option -z nocopyreloc for
> free.  That will make the option easier to understand in the code.
>
> Also please take the opportunity to stamp out some duplication.  Move
> may_need_copy_reloc to be a Symbol function.  Change everything except
> ARM to just call that function.  Change ARM to use
> arm_may_need_copy_reloc which can call that and also check for
> STT_ARM_TFUNC.
>
> Thanks.
>
> Ian
>

Attachment: patch.txt
Description: Text document