This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: PATCH: PR ld/10569: -z max-page-size may not work for linker scripts
- From: Alan Modra <amodra at bigpond dot net dot au>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: binutils at sources dot redhat dot com
- Date: Fri, 28 Aug 2009 12:44:10 +0930
- Subject: Re: PATCH: PR ld/10569: -z max-page-size may not work for linker scripts
- References: <20090828000233.GA23692@lucon.org>
On Thu, Aug 27, 2009 at 05:02:33PM -0700, H.J. Lu wrote:
> PR ld/10569
> * ldlang.c (lang_add_output_format): Call
> bfd_emul_set_maxpagesize/bfd_emul_set_commonpagesize if
> maximum/common page sizes are specified and output target
> isn't the same as default target.
I think this is the wrong place to call bfd_emul_set_maxpagesize
(and the current call in elf32.em is wrong too). You probably should
be calling bfd_emul_set_maxpagesize in open_output. Also,
bfd_emul_get_maxpagesize in fold_name shouldn't be using
default_target. Ditto for commonpagesize.
--
Alan Modra
Australia Development Lab, IBM