Re: [PATCH][GOLD] Add a PT_ARM_EXIDX segment for the .ARM.exidx section.

[=?big5?b?RG91ZyBLd2FuICjD9q62vHcp?= <dougkwan at google dot com>]

I have updated the patch as suggested.

2009-08-10  Doug Kwan  <dougkwan@google.com>

        * arm.cc: Update comments.
        (Target_arm::do_finalize_sections): Add a special PT_ARM_EXIDX
        segment to locate the .ARM.exidx section if present.


2009/8/10 Ian Lance Taylor <iant@google.com>:
> "Doug Kwan (Ãö®¶¼w)" <dougkwan@google.com> writes:
>
>>     This patch add a PT_ARM_EXIDX segment in the program header when
>> there is a .ARM.exidx of type SHT_ARM_EXIDX unless we want relocatable
>> linking or any PHDRS clauses are present in a script.    This is done
>> in layout.cc mainly for simplity.  I am more than happy to move this
>> to arm.cc and define a target hook if there is a better approach.
>
> I think it would work to do this in
> Target_arm<big_endian>::do_finalize_sections.
>
>> +       gold_assert(!find_output_segment(elfcpp::PT_ARM_EXIDX, 0, 0));
>
> Note that find_output_segment does not return a bool, so this should be
>    layout->find_output_segment(...) != NULL
>
> Ian
>

Attachment: patch.txt
Description: Text document