Re: PATCH: Support Intel L1OM

["H.J. Lu" <hjl dot tools at gmail dot com>]

On Mon, Jul 27, 2009 at 12:15 AM, Jan Beulich<JBeulich@novell.com> wrote:
>>>> "H.J. Lu" <hongjiu.lu@intel.com> 25.07.09 16:37 >>>
>>--- bfd/archures.c ? ? (.../fsf/trunk) (revision 6484)
>>+++ bfd/archures.c ? ? (.../branches/l1om) ? ? (revision 6484)
>>...
>>@@ -476,6 +479,7 @@ extern const bfd_arch_info_type bfd_h850
>> extern const bfd_arch_info_type bfd_hppa_arch;
>> extern const bfd_arch_info_type bfd_i370_arch;
>> extern const bfd_arch_info_type bfd_i386_arch;
>>+extern const bfd_arch_info_type bfd_l1om_arch;
>> extern const bfd_arch_info_type bfd_i860_arch;
>> extern const bfd_arch_info_type bfd_i960_arch;
>> extern const bfd_arch_info_type bfd_ia64_arch;
>>@@ -550,6 +554,7 @@ static const bfd_arch_info_type * const
>> ? ? &bfd_hppa_arch,
>> ? ? &bfd_i370_arch,
>> ? ? &bfd_i386_arch,
>>+ ? ?&bfd_l1om_arch,
>> ? ? &bfd_i860_arch,
>> ? ? &bfd_i960_arch,
>> ? ? &bfd_ia64_arch,
>
> Aren't these lists (and further ones modified later in the patch) all sorted
> at least nearly alphabetically? Looking up a specific architecture is certainly
> easier that way...
>

It sounds a good idea. I am checking the enclosed patch as an obvious
fix.

Thanks.

-- 
H.J.
---
Index: archures.c
===================================================================
--- archures.c  (revision 6493)
+++ archures.c  (working copy)
@@ -473,18 +473,17 @@ extern const bfd_arch_info_type bfd_d30v
 extern const bfd_arch_info_type bfd_dlx_arch;
 extern const bfd_arch_info_type bfd_fr30_arch;
 extern const bfd_arch_info_type bfd_frv_arch;
-extern const bfd_arch_info_type bfd_moxie_arch;
 extern const bfd_arch_info_type bfd_h8300_arch;
 extern const bfd_arch_info_type bfd_h8500_arch;
 extern const bfd_arch_info_type bfd_hppa_arch;
 extern const bfd_arch_info_type bfd_i370_arch;
 extern const bfd_arch_info_type bfd_i386_arch;
-extern const bfd_arch_info_type bfd_l1om_arch;
 extern const bfd_arch_info_type bfd_i860_arch;
 extern const bfd_arch_info_type bfd_i960_arch;
 extern const bfd_arch_info_type bfd_ia64_arch;
 extern const bfd_arch_info_type bfd_ip2k_arch;
 extern const bfd_arch_info_type bfd_iq2000_arch;
+extern const bfd_arch_info_type bfd_l1om_arch;
 extern const bfd_arch_info_type bfd_lm32_arch;
 extern const bfd_arch_info_type bfd_m32c_arch;
 extern const bfd_arch_info_type bfd_m32r_arch;
@@ -499,6 +498,7 @@ extern const bfd_arch_info_type bfd_mips
 extern const bfd_arch_info_type bfd_mmix_arch;
 extern const bfd_arch_info_type bfd_mn10200_arch;
 extern const bfd_arch_info_type bfd_mn10300_arch;
+extern const bfd_arch_info_type bfd_moxie_arch;
 extern const bfd_arch_info_type bfd_msp430_arch;
 extern const bfd_arch_info_type bfd_mt_arch;
 extern const bfd_arch_info_type bfd_ns32k_arch;
@@ -521,8 +521,8 @@ extern const bfd_arch_info_type bfd_tic5
 extern const bfd_arch_info_type bfd_tic80_arch;
 extern const bfd_arch_info_type bfd_v850_arch;
 extern const bfd_arch_info_type bfd_vax_arch;
-extern const bfd_arch_info_type bfd_we32k_arch;
 extern const bfd_arch_info_type bfd_w65_arch;
+extern const bfd_arch_info_type bfd_we32k_arch;
 extern const bfd_arch_info_type bfd_xstormy16_arch;
 extern const bfd_arch_info_type bfd_xtensa_arch;
 extern const bfd_arch_info_type bfd_xc16x_arch;
@@ -548,18 +548,17 @@ static const bfd_arch_info_type * const
     &bfd_dlx_arch,
     &bfd_fr30_arch,
     &bfd_frv_arch,
-    &bfd_moxie_arch,
     &bfd_h8300_arch,
     &bfd_h8500_arch,
     &bfd_hppa_arch,
     &bfd_i370_arch,
     &bfd_i386_arch,
-    &bfd_l1om_arch,
     &bfd_i860_arch,
     &bfd_i960_arch,
     &bfd_ia64_arch,
     &bfd_ip2k_arch,
     &bfd_iq2000_arch,
+    &bfd_l1om_arch,
     &bfd_lm32_arch,
     &bfd_m32c_arch,
     &bfd_m32r_arch,
@@ -574,8 +573,9 @@ static const bfd_arch_info_type * const
     &bfd_mmix_arch,
     &bfd_mn10200_arch,
     &bfd_mn10300_arch,
-    &bfd_mt_arch,
+    &bfd_moxie_arch,
     &bfd_msp430_arch,
+    &bfd_mt_arch,
     &bfd_ns32k_arch,
     &bfd_openrisc_arch,
     &bfd_or32_arch,